Skip to content

Update Java Agent launching script for Jenkins connections#2762

Merged
WalterKolczynski-NOAA merged 31 commits into
NOAA-EMC:developfrom
TerrenceMcGuinness-NOAA:harden-launch_java_agent
Aug 2, 2024
Merged

Update Java Agent launching script for Jenkins connections#2762
WalterKolczynski-NOAA merged 31 commits into
NOAA-EMC:developfrom
TerrenceMcGuinness-NOAA:harden-launch_java_agent

Conversation

@TerrenceMcGuinness-NOAA
Copy link
Copy Markdown
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Jul 12, 2024

Description

Made updates to the Jenkins Launching Script for robustness and less ambiguous documentation:

  • Clearer distinction between required user token for the remote api and the systems token for launching
  • Added pre-checks: gh is authenticating, named compliant token and secret file exists
  • More robust Jason based parser of the remote api response for checking the state of the Node connection
  • For cron use a 5 minute pause and recheck was added before re-launching of the java agent
  • Added concise header documentation of requirements and purpose

Type of change

  • Maintenance (code refactor, clean-up, and improved readability)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Tested on the command line

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Issue related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants